iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

media: staging: atomisp: Removed else branch in function

Browse Source 
This patch fixes the checkpatch.pl warning :

WARNING: else is not generally useful after a break or return

Expressions under 'else' branch in function 'gc0310_s_power' are
executed whenever the exppression in 'if' is False. Otherwise, return
from function occurs. Therefore, there is no need in 'else', and it has
been removed.

Link: https://lore.kernel.org/linux-media/20201006081721.GA35979@linux
Signed-off-by: Leonid Kushnir <leonf008@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
This commit is contained in:
Leonid Kushnir 2020-10-06 10:17:21 +02:00 committed by Mauro Carvalho Chehab
parent 3a7c578f39
commit 4658e1dbc3
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/staging/media/atomisp/i2c/atomisp-gc0310.c
View File

@ -874,11 +874,10 @@ static int gc0310_s_power(struct v4l2_subdev *sd, int on)
if (on == 0)
return power_down(sd);
else {
ret = power_up(sd);
if (!ret)
return gc0310_init(sd);
}
ret = power_up(sd);
if (!ret)
return gc0310_init(sd);
return ret;
}