iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Input: exc3000 - fix return value check of wait_for_completion_timeout

Browse Source 
commit 6bb7144c3f upstream.

wait_for_completion_timeout() returns unsigned long not int.
It returns 0 if timed out, and positive if completed.
The check for <= 0 is ambiguous and should be == 0 here
indicating timeout which is the only error case.

Fixes: 102feb1ddf ("Input: exc3000 - factor out vendor data request")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220411105828.22140-1-linmq006@gmail.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Miaoqian Lin
2022-06-28 22:42:35 -07:00
committed by Greg Kroah-Hartman
parent d35d9269dd
commit 478b58ac0b
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/input/touchscreen/exc3000.c
View File

@ -220,6 +220,7 @@ static int exc3000_vendor_data_request(struct exc3000_data *data, u8 *request,
{ {
u8 buf[EXC3000_LEN_VENDOR_REQUEST] = { 0x67, 0x00, 0x42, 0x00, 0x03 }; u8 buf[EXC3000_LEN_VENDOR_REQUEST] = { 0x67, 0x00, 0x42, 0x00, 0x03 };
int ret; int ret;
unsigned long time_left;
mutex_lock(&data->query_lock); mutex_lock(&data->query_lock);
@ -233,9 +234,9 @@ static int exc3000_vendor_data_request(struct exc3000_data *data, u8 *request,
goto out_unlock; goto out_unlock;
if (response) { if (response) {
ret = wait_for_completion_timeout(&data->wait_event, time_left = wait_for_completion_timeout(&data->wait_event,
timeout * HZ); timeout * HZ);
if (ret <= 0) { if (time_left == 0) {
ret = -ETIMEDOUT; ret = -ETIMEDOUT;
goto out_unlock; goto out_unlock;
} }