i2c: Remove redundant comparison in npcm_i2c_reg_slave
In the npcm_i2c_reg_slave() function, there was a redundant comparison that checked if 'bus->slave' was null immediately after assigning it the 'client' value. There were concerns about a potential null dereference because of `client->adapter`, but according to Wolfram Sang, "we trusted ourselves here" Therefore, this comparison is unnecessary. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Rand Deeb <rand.sec96@gmail.com> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
This commit is contained in:
parent
857cc04cdf
commit
48acf82922
@ -1264,9 +1264,6 @@ static int npcm_i2c_reg_slave(struct i2c_client *client)
|
||||
|
||||
bus->slave = client;
|
||||
|
||||
if (!bus->slave)
|
||||
return -EINVAL;
|
||||
|
||||
if (client->flags & I2C_CLIENT_TEN)
|
||||
return -EAFNOSUPPORT;
|
||||
|
||||
|
Loading…
x
Reference in New Issue
Block a user