iio: proximity: srf04: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230919174931.1417681-47-u.kleine-koenig@pengutronix.de Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
This commit is contained in:
parent
2df694f710
commit
4abfc97db9
@ -344,7 +344,7 @@ static int srf04_probe(struct platform_device *pdev)
|
||||
return ret;
|
||||
}
|
||||
|
||||
static int srf04_remove(struct platform_device *pdev)
|
||||
static void srf04_remove(struct platform_device *pdev)
|
||||
{
|
||||
struct iio_dev *indio_dev = platform_get_drvdata(pdev);
|
||||
struct srf04_data *data = iio_priv(indio_dev);
|
||||
@ -355,8 +355,6 @@ static int srf04_remove(struct platform_device *pdev)
|
||||
pm_runtime_disable(data->dev);
|
||||
pm_runtime_set_suspended(data->dev);
|
||||
}
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static int srf04_pm_runtime_suspend(struct device *dev)
|
||||
@ -391,7 +389,7 @@ static const struct dev_pm_ops srf04_pm_ops = {
|
||||
|
||||
static struct platform_driver srf04_driver = {
|
||||
.probe = srf04_probe,
|
||||
.remove = srf04_remove,
|
||||
.remove_new = srf04_remove,
|
||||
.driver = {
|
||||
.name = "srf04-gpio",
|
||||
.of_match_table = of_srf04_match,
|
||||
|
Loading…
Reference in New Issue
Block a user