iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

clk: core: Fix runtime PM sequence in clk_core_unprepare()

Browse Source 
In the original commit 9a34b45397e5 ("clk: Add support for runtime PM"),
the commit message mentioned that pm_runtime_put_sync() would be done
at the end of clk_core_unprepare(). This mirrors the operations in
clk_core_prepare() in the opposite order.

However, the actual code that was added wasn't in the order the commit
message described. Move clk_pm_runtime_put() to the end of
clk_core_unprepare() so that it is in the correct order.

Fixes: 9a34b45397e5 ("clk: Add support for runtime PM")
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Link: https://lore.kernel.org/r/20220822081424.1310926-3-wenst@chromium.org
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
This commit is contained in:
Chen-Yu Tsai 2022-08-22 16:14:24 +08:00 committed by Stephen Boyd
parent 35b0fac808
commit 4b592061f7
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/clk/clk.c
View File

@ -859,13 +859,12 @@ static void clk_core_unprepare(struct clk_core *core)
if (core->ops->unprepare) if (core->ops->unprepare)
core->ops->unprepare(core->hw); core->ops->unprepare(core->hw);
clk_pm_runtime_put(core);
trace_clk_unprepare_complete(core); trace_clk_unprepare_complete(core);
if (core->flags & CLK_OPS_PARENT_ENABLE) if (core->flags & CLK_OPS_PARENT_ENABLE)
clk_core_disable_lock(core->parent); clk_core_disable_lock(core->parent);
clk_core_unprepare(core->parent); clk_core_unprepare(core->parent);
clk_pm_runtime_put(core);
} }
static void clk_core_unprepare_lock(struct clk_core *core) static void clk_core_unprepare_lock(struct clk_core *core)