iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

btrfs: block-group: Fix a memory leak due to missing btrfs_put_block_group()

Browse Source 
In btrfs_read_block_groups(), if we have an invalid block group which
has mixed type (DATA|METADATA) while the fs doesn't have MIXED_GROUPS
feature, we error out without freeing the block group cache.

This patch will add the missing btrfs_put_block_group() to prevent
memory leak.

Note for stable backports: the file to patch in versions <= 5.3 is
fs/btrfs/extent-tree.c

Fixes: 49303381f1 ("Btrfs: bail out if block group has different mixed flag")
CC: stable@vger.kernel.org # 4.9+
Reviewed-by: Anand Jain <anand.jain@oracle.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
Qu Wenruo 2019-10-10 10:39:26 +08:00 committed by David Sterba
parent 44db1216ef
commit 4b654acdae
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
fs/btrfs/block-group.c
View File

@ -1761,6 +1761,7 @@ int btrfs_read_block_groups(struct btrfs_fs_info *info)
btrfs_err(info, btrfs_err(info,
"bg %llu is a mixed block group but filesystem hasn't enabled mixed block groups", "bg %llu is a mixed block group but filesystem hasn't enabled mixed block groups",
cache->key.objectid); cache->key.objectid);
btrfs_put_block_group(cache);
ret = -EINVAL; ret = -EINVAL;
goto error; goto error;
} }