iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tracing/osnoise: Fix missed cpus_read_unlock() in start_per_cpu_kthreads()

Browse Source 
When start_kthread() return error, the cpus_read_unlock() need
to be called.

Link: https://lkml.kernel.org/r/20210831022919.27630-1-qiang.zhang@windriver.com

Cc: <stable@vger.kernel.org>
Fixes: c8895e271f79 ("trace/osnoise: Support hotplug operations")
Acked-by: Daniel Bristot de Oliveira <bristot@kernel.org>
Signed-off-by: Qiang.Zhang <qiang.zhang@windriver.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
This commit is contained in:
Qiang.Zhang 2021-08-31 10:29:19 +08:00 committed by Steven Rostedt (VMware)
parent 5615e088b4
commit 4b6b08f2e4
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
kernel/trace/trace_osnoise.c
View File

@ -1548,7 +1548,7 @@ static int start_kthread(unsigned int cpu)
static int start_per_cpu_kthreads(struct trace_array *tr) static int start_per_cpu_kthreads(struct trace_array *tr)
{ {
struct cpumask *current_mask = &save_cpumask; struct cpumask *current_mask = &save_cpumask;
int retval; int retval = 0;
int cpu; int cpu;
cpus_read_lock(); cpus_read_lock();
@ -1568,13 +1568,13 @@ static int start_per_cpu_kthreads(struct trace_array *tr)
retval = start_kthread(cpu); retval = start_kthread(cpu);
if (retval) { if (retval) {
stop_per_cpu_kthreads(); stop_per_cpu_kthreads();
return retval; break;
} }
} }
cpus_read_unlock(); cpus_read_unlock();
return 0; return retval;
} }
#ifdef CONFIG_HOTPLUG_CPU #ifdef CONFIG_HOTPLUG_CPU