iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

iommu/vt-d: Fix PCI device refcount leak in dmar_dev_scope_init()

Browse Source 
for_each_pci_dev() is implemented by pci_get_device(). The comment of
pci_get_device() says that it will increase the reference count for the
returned pci_dev and also decrease the reference count for the input
pci_dev @from if it is not NULL.

If we break for_each_pci_dev() loop with pdev not NULL, we need to call
pci_dev_put() to decrease the reference count. Add the missing
pci_dev_put() for the error path to avoid reference count leak.

Fixes: 2e4552893038 ("iommu/vt-d: Unify the way to process DMAR device scope array")
Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Link: https://lore.kernel.org/r/20221121113649.190393-3-wangxiongfeng2@huawei.com
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
This commit is contained in:
Xiongfeng Wang 2022-12-01 12:01:27 +08:00 committed by Joerg Roedel
parent afca9e19cc
commit 4bedbbd782
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/iommu/intel/dmar.c
View File

@ -820,6 +820,7 @@ int __init dmar_dev_scope_init(void)
info = dmar_alloc_pci_notify_info(dev, info = dmar_alloc_pci_notify_info(dev,
BUS_NOTIFY_ADD_DEVICE); BUS_NOTIFY_ADD_DEVICE);
if (!info) { if (!info) {
pci_dev_put(dev);
return dmar_dev_scope_status; return dmar_dev_scope_status;
} else { } else {
dmar_pci_bus_add_dev(info); dmar_pci_bus_add_dev(info);