iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drm/rockchip: psr: do not dereference encoder before it is null checked.

Browse Source 
'encoder' is dereferenced before it is null sanity checked, hence we
potentially have a null pointer dereference bug. Instead, initialise
drm_drv from encoder->dev->dev_private after we are sure 'encoder' is
not null.

Fixes: 5182c1a556d7f ("drm/rockchip: add an common abstracted PSR driver")
Cc: stable@vger.kernel.org
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20181013105654.11827-1-enric.balletbo@collabora.com
This commit is contained in:
Enric Balletbo i Serra 2018-10-13 12:56:54 +02:00 committed by Heiko Stuebner
parent 649fdce23c
commit 4eda776c3c
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/gpu/drm/rockchip/rockchip_drm_psr.c
View File

@ -189,12 +189,14 @@ EXPORT_SYMBOL(rockchip_drm_psr_flush_all);
int rockchip_drm_psr_register(struct drm_encoder *encoder, int rockchip_drm_psr_register(struct drm_encoder *encoder,
int (*psr_set)(struct drm_encoder *, bool enable)) int (*psr_set)(struct drm_encoder *, bool enable))
{ {
struct rockchip_drm_private *drm_drv = encoder->dev->dev_private; struct rockchip_drm_private *drm_drv;
struct psr_drv *psr; struct psr_drv *psr;
if (!encoder || !psr_set) if (!encoder || !psr_set)
return -EINVAL; return -EINVAL;
drm_drv = encoder->dev->dev_private;
psr = kzalloc(sizeof(struct psr_drv), GFP_KERNEL); psr = kzalloc(sizeof(struct psr_drv), GFP_KERNEL);
if (!psr) if (!psr)
return -ENOMEM; return -ENOMEM;