iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

printk: console: remove unnecessary safe buffer usage

Browse Source 
Upon registering a console, safe buffers are activated when setting
up the sequence number to replay the log. However, these are already
protected by @console_sem and @syslog_lock. Remove the unnecessary
safe buffer usage.

Signed-off-by: John Ogness <john.ogness@linutronix.de>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Petr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/20210303101528.29901-16-john.ogness@linutronix.de
This commit is contained in:
John Ogness 2021-03-03 11:15:28 +01:00 committed by Petr Mladek
parent a4f9876532
commit 505a27a734
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
kernel/printk/printk.c
View File

@ -2967,9 +2967,7 @@ void register_console(struct console *newcon)
/* /*
* console_unlock(); will print out the buffered messages * console_unlock(); will print out the buffered messages
* for us. * for us.
*/ *
printk_safe_enter_irqsave(flags);
/*
* We're about to replay the log buffer. Only do this to the * We're about to replay the log buffer. Only do this to the
* just-registered console to avoid excessive message spam to * just-registered console to avoid excessive message spam to
* the already-registered consoles. * the already-registered consoles.
@ -2982,11 +2980,9 @@ void register_console(struct console *newcon)
exclusive_console_stop_seq = console_seq; exclusive_console_stop_seq = console_seq;
/* Get a consistent copy of @syslog_seq. */ /* Get a consistent copy of @syslog_seq. */
raw_spin_lock(&syslog_lock); raw_spin_lock_irqsave(&syslog_lock, flags);
console_seq = syslog_seq; console_seq = syslog_seq;
raw_spin_unlock(&syslog_lock); raw_spin_unlock_irqrestore(&syslog_lock, flags);
printk_safe_exit_irqrestore(flags);
} }
console_unlock(); console_unlock();
console_sysfs_notify(); console_sysfs_notify();