iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

sctp: sctp_chunk_length_valid should return bool

Browse Source 
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Marcelo Ricardo Leitner 2016-12-28 09:26:35 -02:00 committed by David S. Miller
parent 66b91d2cd0
commit 509e7a311f
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
net/sctp/sm_statefuns.c
View File

@ -160,23 +160,22 @@ static sctp_disposition_t __sctp_sf_do_9_1_abort(struct net *net,
/* Small helper function that checks if the chunk length /* Small helper function that checks if the chunk length
* is of the appropriate length. The 'required_length' argument * is of the appropriate length. The 'required_length' argument
* is set to be the size of a specific chunk we are testing. * is set to be the size of a specific chunk we are testing.
* Return Values: 1 = Valid length * Return Values: true = Valid length
* 0 = Invalid length * false = Invalid length
* *
*/ */
static inline int static inline bool
sctp_chunk_length_valid(struct sctp_chunk *chunk, sctp_chunk_length_valid(struct sctp_chunk *chunk, __u16 required_length)
__u16 required_length)
{ {
__u16 chunk_length = ntohs(chunk->chunk_hdr->length); __u16 chunk_length = ntohs(chunk->chunk_hdr->length);
/* Previously already marked? */ /* Previously already marked? */
if (unlikely(chunk->pdiscard)) if (unlikely(chunk->pdiscard))
return 0; return false;
if (unlikely(chunk_length < required_length)) if (unlikely(chunk_length < required_length))
return 0; return false;
return 1; return true;
} }
/********************************************************** /**********************************************************