iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libata-core: Document some limits/assumptions about ID_ATA

Browse Source 
Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
This commit is contained in:
Alan Cox 2007-08-08 14:27:00 +01:00 committed by Jeff Garzik
parent baf4fdfaaf
commit 50a9901878
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/ata/libata-core.c
View File

@ -1618,6 +1618,9 @@ static u32 ata_pio_mask_no_iordy(const struct ata_device *adev)
* devices. This function also issues ATA_CMD_INIT_DEV_PARAMS * devices. This function also issues ATA_CMD_INIT_DEV_PARAMS
* for pre-ATA4 drives. * for pre-ATA4 drives.
* *
* FIXME: ATA_CMD_ID_ATA is optional for early drives and right
* now we abort if we hit that case.
*
* LOCKING: * LOCKING:
* Kernel thread context (may sleep) * Kernel thread context (may sleep)
* *
@ -1745,10 +1748,13 @@ int ata_dev_read_id(struct ata_device *dev, unsigned int *p_class,
/* /*
* The exact sequence expected by certain pre-ATA4 drives is: * The exact sequence expected by certain pre-ATA4 drives is:
* SRST RESET * SRST RESET
* IDENTIFY * IDENTIFY (optional in early ATA)
* INITIALIZE DEVICE PARAMETERS * INITIALIZE DEVICE PARAMETERS (later IDE and ATA)
* anything else.. * anything else..
* Some drives were very specific about that exact sequence. * Some drives were very specific about that exact sequence.
*
* Note that ATA4 says lba is mandatory so the second check
* shoud never trigger.
*/ */
if (ata_id_major_version(id) < 4 || !ata_id_has_lba(id)) { if (ata_id_major_version(id) < 4 || !ata_id_has_lba(id)) {
err_mask = ata_dev_init_params(dev, id[3], id[6]); err_mask = ata_dev_init_params(dev, id[3], id[6]);