iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

PCI/pwrctl: only call of_platform_populate() if CONFIG_OF is enabled

Browse Source 
If of_platform_populate() is called when CONFIG_OF is not defined this
leads to spurious error messages of the following type:
 pci 0000:00:01.1: failed to populate child OF nodes (-19)
 pci 0000:00:02.1: failed to populate child OF nodes (-19)

Fixes: 8fb18619d910 ("PCI/pwrctl: Create platform devices for child OF nodes of the port node")
Signed-off-by: Bert Karwatzki <spasswolf@web.de>
Closes: https://lore.kernel.org/all/20240702173255.39932-1-superm1@kernel.org/
Reviewed-by: Lukas Wunner <lukas@wunner.de>
Acked-by: Krzysztof Wilczyński <kw@linux.com>
Reported-by: Praveenkumar Patil <PraveenKumar.Patil@amd.com>
Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Link: https://lore.kernel.org/r/20240707183829.41519-1-spasswolf@web.de
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
This commit is contained in:
Bert Karwatzki 2024-07-07 20:38:28 +02:00 committed by Bartosz Golaszewski
parent eba6d0f88b
commit 50b040ef37
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/pci/bus.c
View File

@ -356,7 +356,7 @@ void pci_bus_add_device(struct pci_dev *dev)
pci_dev_assign_added(dev, true); pci_dev_assign_added(dev, true);
if (pci_is_bridge(dev)) { if (IS_ENABLED(CONFIG_OF) && pci_is_bridge(dev)) {
retval = of_platform_populate(dev->dev.of_node, NULL, NULL, retval = of_platform_populate(dev->dev.of_node, NULL, NULL,
&dev->dev); &dev->dev);
if (retval) if (retval)