iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

crypto: ux500 - Adjust two condition checks in ux500_cryp_probe()

Browse Source 
The local variable "cryp_error" was used only for two condition checks.

* Check the return values from these function calls directly instead.

* Delete this variable which became unnecessary with this refactoring.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Markus Elfring
2018-02-14 10:38:44 +01:00
committed by Herbert Xu
parent dbbd5d1eff
commit 50ca524d7c
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/crypto/ux500/cryp/cryp_core.c
View File

@ -1404,7 +1404,6 @@ static void cryp_algs_unregister_all(void)
static int ux500_cryp_probe(struct platform_device *pdev) static int ux500_cryp_probe(struct platform_device *pdev)
{ {
int ret; int ret;
int cryp_error = 0;
struct resource *res = NULL; struct resource *res = NULL;
struct resource *res_irq = NULL; struct resource *res_irq = NULL;
struct cryp_device_data *device_data; struct cryp_device_data *device_data;
@ -1478,15 +1477,13 @@ static int ux500_cryp_probe(struct platform_device *pdev)
goto out_clk_unprepare; goto out_clk_unprepare;
} }
cryp_error = cryp_check(device_data); if (cryp_check(device_data)) {
if (cryp_error != 0) {
dev_err(dev, "[%s]: cryp_init() failed!", __func__); dev_err(dev, "[%s]: cryp_init() failed!", __func__);
ret = -EINVAL; ret = -EINVAL;
goto out_power; goto out_power;
} }
cryp_error = cryp_configure_protection(device_data, &prot); if (cryp_configure_protection(device_data, &prot)) {
if (cryp_error != 0) {
dev_err(dev, "[%s]: cryp_configure_protection() failed!", dev_err(dev, "[%s]: cryp_configure_protection() failed!",
__func__); __func__);
ret = -EINVAL; ret = -EINVAL;