lib/ts_kmp.c: replace zero-length array with flexible-array member
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertenly introduced[3] to the codebase from now on. This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] https://github.com/KSPP/linux/issues/21 [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour") Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Link: http://lkml.kernel.org/r/20200211205948.GA26459@embeddedor Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
parent
842ae1f52b
commit
51022f8715
@ -36,7 +36,7 @@ struct ts_kmp
|
||||
{
|
||||
u8 * pattern;
|
||||
unsigned int pattern_len;
|
||||
unsigned int prefix_tbl[0];
|
||||
unsigned int prefix_tbl[];
|
||||
};
|
||||
|
||||
static unsigned int kmp_find(struct ts_config *conf, struct ts_state *state)
|
||||
|
Loading…
x
Reference in New Issue
Block a user