NFC: fdp: fix incorrect free object
The address of fw_vsc_cfg is on stack. Releasing it with devm_kfree() is incorrect, which may result in a system crash or other security impacts. The expected object to free is *fw_vsc_cfg. Signed-off-by: Pan Bian <bianpan2016@163.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
committed by
David S. Miller
parent
f75359f3ac
commit
517ce4e933
@ -259,7 +259,7 @@ static void fdp_nci_i2c_read_device_properties(struct device *dev,
|
|||||||
*fw_vsc_cfg, len);
|
*fw_vsc_cfg, len);
|
||||||
|
|
||||||
if (r) {
|
if (r) {
|
||||||
devm_kfree(dev, fw_vsc_cfg);
|
devm_kfree(dev, *fw_vsc_cfg);
|
||||||
goto vsc_read_err;
|
goto vsc_read_err;
|
||||||
}
|
}
|
||||||
} else {
|
} else {
|
||||||
|
Reference in New Issue
Block a user