iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

greybus: protocol: warn on protocol put errors

Browse Source 
Issue a warning if we fail to look up a protocol when dropping a
reference.

This should never happen as we hold a reference to the protocol module
and protocols should only be deregistered at module unload.

Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
This commit is contained in:
Johan Hovold 2015-10-13 19:10:25 +02:00 committed by Greg Kroah-Hartman
parent 78033844da
commit 519bf3c3b9
1 changed files with 6 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
drivers/staging/greybus/protocol.c
View File

@ -188,7 +188,6 @@ void gb_protocol_put(struct gb_protocol *protocol)
u8 id;
u8 major;
u8 minor;
u8 protocol_count;
id = protocol->id;
major = protocol->major;
@ -196,16 +195,11 @@ void gb_protocol_put(struct gb_protocol *protocol)
spin_lock_irq(&gb_protocols_lock);
protocol = gb_protocol_find(id, major, minor);
if (protocol) {
protocol_count = protocol->count;
if (protocol_count)
protocol->count--;
module_put(protocol->owner);
}
if (WARN_ON(!protocol || !protocol->count))
goto out;
protocol->count--;
module_put(protocol->owner);
out:
spin_unlock_irq(&gb_protocols_lock);
if (protocol)
WARN_ON(!protocol_count);
else
pr_err("protocol id %hhu version %hhu.%hhu not found\n",
id, major, minor);
}