iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

RDMA: Do not used __packed in uapi headers

Browse Source 
__packed is not available in linux/types.h, so we cannot use it in
the uapi headers.

The construction struct ABC {} __packed; may still compile even if
__packed is not defined, however it simply creates a variable called
__packed, and doesn't set the alignment.

All these uses of packed are on structs that already have aligned
members.

While use in hfi may indicate the struct itself is unaligned,
the use in ocrdma is on a UHW struct which should never be unaligned,
so just delete it there.

Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
This commit is contained in:
Jason Gunthorpe 2018-02-07 16:45:51 -07:00
parent d480bb50d2
commit 5229f87efc
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
include/uapi/rdma/hfi/hfi1_user.h
View File

@ -219,7 +219,7 @@ struct sdma_req_info {
* in charge of managing its own ring.
*/
__u16 comp_idx;
} __packed;
} __attribute__((__packed__));
/*
* SW KDETH header.
@ -230,7 +230,7 @@ struct hfi1_kdeth_header {
__le16 jkey;
__le16 hcrc;
__le32 swdata[7];
} __packed;
} __attribute__((__packed__));
/*
* Structure describing the headers that User space uses. The
@ -241,7 +241,7 @@ struct hfi1_pkt_header {
__be16 lrh[4];
__be32 bth[3];
struct hfi1_kdeth_header kdeth;
} __packed;
} __attribute__((__packed__));
/*

2
include/uapi/rdma/ocrdma-abi.h
View File

@ -127,7 +127,7 @@ struct ocrdma_create_qp_uresp {
__u32 db_rq_offset;
__u32 db_shift;
__u64 rsvd[11];
} __packed;
};
struct ocrdma_create_srq_uresp {
__u16 rq_dbid;