staging: vt6655: Convert macro MACvSetBBType to function
Convert macro to static function. Multiline macros are not liked by kernel community. Rename variable dwOrgValue to reg_value and byTyp to mask to avoid CamelCase which is not accepted by checkpatch.pl. Change variable declaration to u32 as this improves readability. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/bd512f940427615ed4b134dd04f14095875eec5b.1661666677.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
87dec3259a
commit
52b735c96a
@ -55,6 +55,16 @@ static const unsigned short cwRXBCNTSFOff[MAX_RATE] = {
|
||||
|
||||
/*--------------------- Static Functions --------------------------*/
|
||||
|
||||
static void MACvSetBBType(void __iomem *iobase, u32 mask)
|
||||
{
|
||||
u32 reg_value;
|
||||
|
||||
reg_value = ioread32(iobase + MAC_REG_ENCFG);
|
||||
reg_value = reg_value & ~ENCFG_BBTYPE_MASK;
|
||||
reg_value = reg_value | mask;
|
||||
iowrite32(reg_value, iobase + MAC_REG_ENCFG);
|
||||
}
|
||||
|
||||
/*--------------------- Export Functions --------------------------*/
|
||||
|
||||
/*
|
||||
|
@ -543,15 +543,6 @@
|
||||
#define MACvSelectPage1(iobase) \
|
||||
iowrite8(1, iobase + MAC_REG_PAGE1SEL)
|
||||
|
||||
#define MACvSetBBType(iobase, byTyp) \
|
||||
do { \
|
||||
unsigned long dwOrgValue; \
|
||||
dwOrgValue = ioread32(iobase + MAC_REG_ENCFG); \
|
||||
dwOrgValue = dwOrgValue & ~ENCFG_BBTYPE_MASK; \
|
||||
dwOrgValue = dwOrgValue | (unsigned long)byTyp; \
|
||||
iowrite32((u32)dwOrgValue, iobase + MAC_REG_ENCFG); \
|
||||
} while (0)
|
||||
|
||||
#define MACvSetRFLE_LatchBase(iobase) \
|
||||
vt6655_mac_word_reg_bits_on(iobase, MAC_REG_SOFTPWRCTL, SOFTPWRCTL_RFLEOPT)
|
||||
|
||||
|
Loading…
x
Reference in New Issue
Block a user