iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

crypto: hisilicon/zip - replace 'sprintf' with 'scnprintf'

Browse Source 
Replace 'sprintf' with 'scnprintf' to avoid overrun.

Signed-off-by: Yang Shen <shenyang39@huawei.com>
Reviewed-by: Zhou Wang <wangzhou1@hisilicon.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Yang Shen 2020-09-07 16:21:56 +08:00 committed by Herbert Xu
parent 4b33f057ee
commit 533b207929
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/crypto/hisilicon/zip/zip_main.c
View File

@ -428,7 +428,7 @@ static ssize_t hisi_zip_ctrl_debug_read(struct file *filp, char __user *buf,
return -EINVAL; return -EINVAL;
} }
spin_unlock_irq(&file->lock); spin_unlock_irq(&file->lock);
ret = sprintf(tbuf, "%u\n", val); ret = scnprintf(tbuf, sizeof(tbuf), "%u\n", val);
return simple_read_from_buffer(buf, count, pos, tbuf, ret); return simple_read_from_buffer(buf, count, pos, tbuf, ret);
} }
@ -518,9 +518,10 @@ static int hisi_zip_core_debug_init(struct hisi_qm *qm)
for (i = 0; i < HZIP_CORE_NUM; i++) { for (i = 0; i < HZIP_CORE_NUM; i++) {
if (i < HZIP_COMP_CORE_NUM) if (i < HZIP_COMP_CORE_NUM)
sprintf(buf, "comp_core%d", i); scnprintf(buf, sizeof(buf), "comp_core%d", i);
else else
sprintf(buf, "decomp_core%d", i - HZIP_COMP_CORE_NUM); scnprintf(buf, sizeof(buf), "decomp_core%d",
i - HZIP_COMP_CORE_NUM);
regset = devm_kzalloc(dev, sizeof(*regset), GFP_KERNEL); regset = devm_kzalloc(dev, sizeof(*regset), GFP_KERNEL);
if (!regset) if (!regset)