From 54c9fb7e64fd3f0da1570e3d1c5446605e83210e Mon Sep 17 00:00:00 2001 From: Matthew Brost Date: Mon, 10 Jul 2023 07:41:21 -0700 Subject: [PATCH] drm/xe: Use internal VM flags in xe_vm_create xe_vm_create used the IOCTL create flags in a few places rather than the internal VM flags and this just happened to work as these values matched. This is risky (and incorrect) as the internal flag values are free to change. Fix this and use the internal VM flag values. Signed-off-by: Matthew Brost Reviewed-by: Matthew Auld Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/xe/xe_vm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c index bd143acbde0e..a9cf62f7aac6 100644 --- a/drivers/gpu/drm/xe/xe_vm.c +++ b/drivers/gpu/drm/xe/xe_vm.c @@ -1253,13 +1253,13 @@ struct xe_vm *xe_vm_create(struct xe_device *xe, u32 flags) vm->batch_invalidate_tlb = true; } - if (flags & DRM_XE_VM_CREATE_COMPUTE_MODE) { + if (flags & XE_VM_FLAG_COMPUTE_MODE) { INIT_WORK(&vm->preempt.rebind_work, preempt_rebind_work_func); vm->flags |= XE_VM_FLAG_COMPUTE_MODE; vm->batch_invalidate_tlb = false; } - if (flags & DRM_XE_VM_CREATE_ASYNC_BIND_OPS) { + if (flags & XE_VM_FLAG_ASYNC_BIND_OPS) { vm->async_ops.fence.context = dma_fence_context_alloc(1); vm->flags |= XE_VM_FLAG_ASYNC_BIND_OPS; }