iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

greybus: uart: fix the clean up while uart initiates connection unsucessfully

Browse Source 
There is lack of unregister and free the tty driver.
This patch fixes it.

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
This commit is contained in:
Phong Tran 2015-06-10 21:03:17 +07:00 committed by Greg Kroah-Hartman
parent 3d0421e0ab
commit 55a8e35503
1 changed files with 12 additions and 6 deletions

18
drivers/staging/greybus/uart.c

@ -586,20 +586,22 @@ static int gb_uart_connection_init(struct gb_connection *connection)
}
gb_tty = kzalloc(sizeof(*gb_tty), GFP_KERNEL);
if (!gb_tty)
return -ENOMEM;
if (!gb_tty) {
retval = -ENOMEM;
goto error_alloc;
}
gb_tty->buffer_payload_max =
gb_operation_get_payload_size_max(connection);
if (!gb_tty->buffer_payload_max) {
kfree(gb_tty);
return -EINVAL;
retval = -EINVAL;
goto error_payload;
}
gb_tty->buffer = kzalloc(gb_tty->buffer_payload_max, GFP_KERNEL);
if (!gb_tty->buffer) {
kfree(gb_tty);
return -ENOMEM;
retval = -ENOMEM;
goto error_payload;
}
gb_tty->connection = connection;
@ -654,7 +656,11 @@ error:
error_version:
connection->private = NULL;
kfree(gb_tty->buffer);
error_payload:
kfree(gb_tty);
error_alloc:
if (atomic_dec_return(&reference_count) == 0)
gb_tty_exit();
return retval;
}