iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

rtc: mxc_v2: Add missing clk_disable_unprepare()

Browse Source 
The call to clk_disable_unprepare() is left out in the error handling of
devm_rtc_allocate_device. Add it back.

Fixes: 5490a1e018a4 ("rtc: mxc_v2: fix possible race condition")
Signed-off-by: GUO Zihua <guozihua@huawei.com>
Link: https://lore.kernel.org/r/20221122085046.21689-1-guozihua@huawei.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
This commit is contained in:
GUO Zihua 2022-11-22 16:50:46 +08:00 committed by Alexandre Belloni
parent 3bb23f1f9d
commit 55d5a86618
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/rtc/rtc-mxc_v2.c
View File

@ -336,8 +336,10 @@ static int mxc_rtc_probe(struct platform_device *pdev)
} }
pdata->rtc = devm_rtc_allocate_device(&pdev->dev); pdata->rtc = devm_rtc_allocate_device(&pdev->dev);
if (IS_ERR(pdata->rtc)) if (IS_ERR(pdata->rtc)) {
clk_disable_unprepare(pdata->clk);
return PTR_ERR(pdata->rtc); return PTR_ERR(pdata->rtc);
}
pdata->rtc->ops = &mxc_rtc_ops; pdata->rtc->ops = &mxc_rtc_ops;
pdata->rtc->range_max = U32_MAX; pdata->rtc->range_max = U32_MAX;