iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

staging: greybus: fix symbolic permission coding style issues

Browse Source 
Fix "Octal permissions are preffered than symbolic ones" issues.

Signed-off-by: Gioh Kim <gi-oh.kim@profitbricks.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Gioh Kim 2017-02-09 17:30:12 +01:00 committed by Greg Kroah-Hartman
parent 461ab8077d
commit 563a8412c5
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/staging/greybus/es2.c
View File

@ -1152,7 +1152,7 @@ static void usb_log_enable(struct es2_ap_dev *es2)
if (IS_ERR(es2->apb_log_task)) if (IS_ERR(es2->apb_log_task))
return; return;
/* XXX We will need to rename this per APB */ /* XXX We will need to rename this per APB */
es2->apb_log_dentry = debugfs_create_file("apb_log", S_IRUGO, es2->apb_log_dentry = debugfs_create_file("apb_log", 0444,
gb_debugfs_get(), es2, gb_debugfs_get(), es2,
&apb_log_fops); &apb_log_fops);
} }
@ -1409,7 +1409,7 @@ static int ap_probe(struct usb_interface *interface,
/* XXX We will need to rename this per APB */ /* XXX We will need to rename this per APB */
es2->apb_log_enable_dentry = debugfs_create_file("apb_log_enable", es2->apb_log_enable_dentry = debugfs_create_file("apb_log_enable",
(S_IWUSR | S_IRUGO), 0644,
gb_debugfs_get(), es2, gb_debugfs_get(), es2,
&apb_log_enable_fops); &apb_log_enable_fops);

2
drivers/staging/greybus/loopback.c
View File

@ -1215,7 +1215,7 @@ static int gb_loopback_probe(struct gb_bundle *bundle,
/* Create per-connection sysfs and debugfs data-points */ /* Create per-connection sysfs and debugfs data-points */
snprintf(name, sizeof(name), "raw_latency_%s", snprintf(name, sizeof(name), "raw_latency_%s",
dev_name(&connection->bundle->dev)); dev_name(&connection->bundle->dev));
gb->file = debugfs_create_file(name, S_IFREG | S_IRUGO, gb_dev.root, gb, gb->file = debugfs_create_file(name, S_IFREG | 0444, gb_dev.root, gb,
&gb_loopback_debugfs_latency_ops); &gb_loopback_debugfs_latency_ops);
gb->id = ida_simple_get(&loopback_ida, 0, 0, GFP_KERNEL); gb->id = ida_simple_get(&loopback_ida, 0, 0, GFP_KERNEL);

6
drivers/staging/greybus/svc.c
View File

@ -803,11 +803,11 @@ static void gb_svc_pwrmon_debugfs_init(struct gb_svc *svc)
rail->svc = svc; rail->svc = svc;
dir = debugfs_create_dir(fname, dent); dir = debugfs_create_dir(fname, dent);
debugfs_create_file("voltage_now", S_IRUGO, dir, rail, debugfs_create_file("voltage_now", 0444, dir, rail,
&pwrmon_debugfs_voltage_fops); &pwrmon_debugfs_voltage_fops);
debugfs_create_file("current_now", S_IRUGO, dir, rail, debugfs_create_file("current_now", 0444, dir, rail,
&pwrmon_debugfs_current_fops); &pwrmon_debugfs_current_fops);
debugfs_create_file("power_now", S_IRUGO, dir, rail, debugfs_create_file("power_now", 0444, dir, rail,
&pwrmon_debugfs_power_fops); &pwrmon_debugfs_power_fops);
} }