iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

signals: do_signal_stop(): use signal_group_exit()

Browse Source 
do_signal_stop() needs signal_group_exit() but checks sig->group_exit_task.
 This (optimization) is correct, SIGNAL_STOP_DEQUEUED and SIGNAL_GROUP_EXIT
are mutually exclusive, but looks confusing.  Use signal_group_exit(), this
is not fastpath, the code clarity is more important.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Roland McGrath <roland@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Oleg Nesterov 2008-04-30 00:52:36 -07:00 committed by Linus Torvalds
parent 2acb024d55
commit 573cf9ad72
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
kernel/signal.c
View File

@ -1717,7 +1717,7 @@ static int do_signal_stop(int signr)
struct task_struct *t; struct task_struct *t;
if (!likely(sig->flags & SIGNAL_STOP_DEQUEUED) || if (!likely(sig->flags & SIGNAL_STOP_DEQUEUED) ||
unlikely(sig->group_exit_task)) unlikely(signal_group_exit(sig)))
return 0; return 0;
/* /*
* There is no group stop already in progress. * There is no group stop already in progress.