iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Tools: hv: in kvp_set_ip_info free mac_addr right after usage

Browse Source 
... to simplify error path in upcoming changes.

Signed-off-by: Olaf Hering <olaf@aepfle.de>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Olaf Hering 2013-08-04 16:41:24 +02:00 committed by Greg Kroah-Hartman
parent dafffd88e8
commit 57969af029
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tools/hv/hv_kvp_daemon.c
View File

@ -1299,6 +1299,7 @@ static int kvp_set_ip_info(char *if_name, struct hv_kvp_ipaddr_value *new_val)
} }
error = kvp_write_file(file, "HWADDR", "", mac_addr); error = kvp_write_file(file, "HWADDR", "", mac_addr);
free(mac_addr);
if (error) if (error)
goto setval_error; goto setval_error;
@ -1344,7 +1345,6 @@ static int kvp_set_ip_info(char *if_name, struct hv_kvp_ipaddr_value *new_val)
goto setval_error; goto setval_error;
setval_done: setval_done:
free(mac_addr);
fclose(file); fclose(file);
/* /*
@ -1358,7 +1358,6 @@ setval_done:
setval_error: setval_error:
syslog(LOG_ERR, "Failed to write config file"); syslog(LOG_ERR, "Failed to write config file");
free(mac_addr);
fclose(file); fclose(file);
return error; return error;
} }