iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

media: atomisp: don't produce errs for ignored IRQs

Browse Source 
Depending on the ISP-specific HAS_NO_INPUT_FORMATTER macro,
some IRQs will be ignored by the driver. Yet, those keep
happening, as reported by this debug print:

	[   61.620746] atomisp-isp2 0000:00:03.0: atomisp_css_irq_enable: css irq info 0x00000004: disable.

Causing this warning:
	[   61.620749] atomisp-isp2 0000:00:03.0: atomisp_css_irq_enable:Invalid irq info.

Well, if this is a normal situation, just ignore it without
warnings.

Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
This commit is contained in:
Mauro Carvalho Chehab 2020-05-20 08:46:17 +02:00
parent cf3cd3b05e
commit 58d6ccc264
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/staging/media/atomisp/pci/sh_css.c
View File

@ -2660,11 +2660,16 @@ enum ia_css_err ia_css_irq_enable(
case IA_CSS_IRQ_INFO_INPUT_SYSTEM_ERROR:
irq = virq_isys_csi;
break;
#endif
#if !defined(HAS_NO_INPUT_FORMATTER)
case IA_CSS_IRQ_INFO_IF_ERROR:
irq = virq_ifmt0_id;
break;
#else
case IA_CSS_IRQ_INFO_CSS_RECEIVER_SOF:
case IA_CSS_IRQ_INFO_CSS_RECEIVER_EOF:
case IA_CSS_IRQ_INFO_INPUT_SYSTEM_ERROR:
case IA_CSS_IRQ_INFO_IF_ERROR:
/* Just ignore those unused IRQs without printing errors */
return IA_CSS_SUCCESS;
#endif
case IA_CSS_IRQ_INFO_DMA_ERROR:
irq = virq_dma;