iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

i40e: Fix an NULL vs IS_ERR() bug for debugfs_create_dir()

Browse Source 
[ Upstream commit 043b1f185f ]

The debugfs_create_dir() function returns error pointers.
It never returns NULL. Most incorrect error checks were fixed,
but the one in i40e_dbg_init() was forgotten.

Fix the remaining error check.

Fixes: 02e9c29081 ("i40e: debugfs interface")
Signed-off-by: Wang Ming <machel@vivo.com>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Wang Ming
2023-07-13 09:42:39 +08:00
committed by Greg Kroah-Hartman
parent c9b936984d
commit 5a40483557
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/ethernet/intel/i40e/i40e_debugfs.c
View File

@ -1839,7 +1839,7 @@ void i40e_dbg_pf_exit(struct i40e_pf *pf)
void i40e_dbg_init(void) void i40e_dbg_init(void)
{ {
i40e_dbg_root = debugfs_create_dir(i40e_driver_name, NULL); i40e_dbg_root = debugfs_create_dir(i40e_driver_name, NULL);
if (!i40e_dbg_root) if (IS_ERR(i40e_dbg_root))
pr_info("init of debugfs failed\n"); pr_info("init of debugfs failed\n");
} }