iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ntb: Fix calculation ntb_transport_tx_free_entry()

Browse Source 
ntb_transport_tx_free_entry() never returns 0 with the current
calculation. If head == tail, then it would return qp->tx_max_entry.
Change compare to tail >= head and when they are equal, a 0 would be
returned.

Fixes: e74bfeedad ("NTB: Add flow control to the ntb_netdev")
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: renlonglong <ren.longlong@h3c.com>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
This commit is contained in:
Dave Jiang 2023-08-22 09:04:57 -07:00 committed by Jon Mason
parent f195a1a6fe
commit 5a7693e6bb
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/ntb/ntb_transport.c
View File

@ -2429,7 +2429,7 @@ unsigned int ntb_transport_tx_free_entry(struct ntb_transport_qp *qp)
unsigned int head = qp->tx_index; unsigned int head = qp->tx_index;
unsigned int tail = qp->remote_rx_info->entry; unsigned int tail = qp->remote_rx_info->entry;
return tail > head ? tail - head : qp->tx_max_entry + tail - head; return tail >= head ? tail - head : qp->tx_max_entry + tail - head;
} }
EXPORT_SYMBOL_GPL(ntb_transport_tx_free_entry); EXPORT_SYMBOL_GPL(ntb_transport_tx_free_entry);