iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

phy: marvell: phy-mvebu-cp110-comphy: Add of_node_put() before return

Browse Source 
Each iteration of for_each_available_child_of_node puts the previous
node, but in the case of a return from the middle of the loop, there is
no put, thus causing a memory leak. Hence add an of_node_put before the
return in two places.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
This commit is contained in:
Nishka Dasgupta 2019-07-23 16:23:27 +05:30 committed by Kishon Vijay Abraham I
parent 8d160f6b49
commit 5b43a20ac6
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/phy/marvell/phy-mvebu-cp110-comphy.c
View File

@ -626,12 +626,16 @@ static int mvebu_comphy_probe(struct platform_device *pdev)
} }
lane = devm_kzalloc(&pdev->dev, sizeof(*lane), GFP_KERNEL); lane = devm_kzalloc(&pdev->dev, sizeof(*lane), GFP_KERNEL);
if (!lane) if (!lane) {
of_node_put(child);
return -ENOMEM; return -ENOMEM;
}
phy = devm_phy_create(&pdev->dev, child, &mvebu_comphy_ops); phy = devm_phy_create(&pdev->dev, child, &mvebu_comphy_ops);
if (IS_ERR(phy)) if (IS_ERR(phy)) {
of_node_put(child);
return PTR_ERR(phy); return PTR_ERR(phy);
}
lane->priv = priv; lane->priv = priv;
lane->mode = PHY_MODE_INVALID; lane->mode = PHY_MODE_INVALID;