iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

crypto: hisilicon/qm - flush all work before driver removed

Browse Source 
Before removing the driver, flush inter-function communication
work, and subsequent communication work is not processed.
This prevents communication threads from accessing released memory.

Fixes: ("crypto: hisilicon/qm - enable PF and VFs communication")
Signed-off-by: Weili Qian <qianweili@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Weili Qian
2023-07-14 19:41:35 +08:00
committed by Herbert Xu
parent 1e3b2e8055
commit 5cd4ed98cf
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/crypto/hisilicon/qm.c
View File

@ -954,6 +954,11 @@ static irqreturn_t qm_mb_cmd_irq(int irq, void *data)
if (!val) if (!val)
return IRQ_NONE; return IRQ_NONE;
if (test_bit(QM_DRIVER_REMOVING, &qm->misc_ctl)) {
dev_warn(&qm->pdev->dev, "Driver is down, message cannot be processed!\n");
return IRQ_HANDLED;
}
schedule_work(&qm->cmd_process); schedule_work(&qm->cmd_process);
return IRQ_HANDLED; return IRQ_HANDLED;
@ -2743,6 +2748,9 @@ void hisi_qm_wait_task_finish(struct hisi_qm *qm, struct hisi_qm_list *qm_list)
test_bit(QM_RESETTING, &qm->misc_ctl)) test_bit(QM_RESETTING, &qm->misc_ctl))
msleep(WAIT_PERIOD); msleep(WAIT_PERIOD);
if (test_bit(QM_SUPPORT_MB_COMMAND, &qm->caps))
flush_work(&qm->cmd_process);
udelay(REMOVE_WAIT_DELAY); udelay(REMOVE_WAIT_DELAY);
} }
EXPORT_SYMBOL_GPL(hisi_qm_wait_task_finish); EXPORT_SYMBOL_GPL(hisi_qm_wait_task_finish);