can: kvaser_usb: Fix use of uninitialized completion
commitcd7f30e174
upstream. flush_comp is initialized when CMD_FLUSH_QUEUE is sent to the device and completed when the device sends CMD_FLUSH_QUEUE_RESP. This causes completion of uninitialized completion if the device sends CMD_FLUSH_QUEUE_RESP before CMD_FLUSH_QUEUE is ever sent (e.g. as a response to a flush by a previously bound driver, or a misbehaving device). Fix that by initializing flush_comp in kvaser_usb_init_one() like the other completions. This issue is only triggerable after RX URBs have been set up, i.e. the interface has been opened at least once. Cc: stable@vger.kernel.org Fixes:aec5fb2268
("can: kvaser_usb: Add support for Kvaser USB hydra family") Tested-by: Jimmy Assarsson <extja@kvaser.com> Signed-off-by: Anssi Hannula <anssi.hannula@bitwise.fi> Signed-off-by: Jimmy Assarsson <extja@kvaser.com> Link: https://lore.kernel.org/all/20221010150829.199676-3-extja@kvaser.com Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
b239a0993a
commit
5d1cb7bfad
@ -690,6 +690,7 @@ static int kvaser_usb_init_one(struct kvaser_usb *dev, int channel)
|
|||||||
init_usb_anchor(&priv->tx_submitted);
|
init_usb_anchor(&priv->tx_submitted);
|
||||||
init_completion(&priv->start_comp);
|
init_completion(&priv->start_comp);
|
||||||
init_completion(&priv->stop_comp);
|
init_completion(&priv->stop_comp);
|
||||||
|
init_completion(&priv->flush_comp);
|
||||||
priv->can.ctrlmode_supported = 0;
|
priv->can.ctrlmode_supported = 0;
|
||||||
|
|
||||||
priv->dev = dev;
|
priv->dev = dev;
|
||||||
|
@ -1886,7 +1886,7 @@ static int kvaser_usb_hydra_flush_queue(struct kvaser_usb_net_priv *priv)
|
|||||||
{
|
{
|
||||||
int err;
|
int err;
|
||||||
|
|
||||||
init_completion(&priv->flush_comp);
|
reinit_completion(&priv->flush_comp);
|
||||||
|
|
||||||
err = kvaser_usb_hydra_send_simple_cmd(priv->dev, CMD_FLUSH_QUEUE,
|
err = kvaser_usb_hydra_send_simple_cmd(priv->dev, CMD_FLUSH_QUEUE,
|
||||||
priv->channel);
|
priv->channel);
|
||||||
|
Reference in New Issue
Block a user