iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net: txgbe: Fix unsigned comparison to zero in txgbe_calc_eeprom_checksum()

Browse Source 
The error checks on checksum for a negative error return always fails because
it is unsigned and can never be negative.

Fixes: 049fe5365324 ("net: txgbe: Add operations to interact with firmware")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
YueHaibing 2022-11-05 16:07:22 +08:00 committed by Jakub Kicinski
parent a068d33e54
commit 5e2ea7801f
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/net/ethernet/wangxun/txgbe/txgbe_hw.c
View File

@ -200,10 +200,11 @@ static int txgbe_calc_eeprom_checksum(struct txgbe_hw *hw, u16 *checksum)
if (eeprom_ptrs) if (eeprom_ptrs)
kvfree(eeprom_ptrs); kvfree(eeprom_ptrs);
*checksum = TXGBE_EEPROM_SUM - *checksum; if (*checksum > TXGBE_EEPROM_SUM)
if (*checksum < 0)
return -EINVAL; return -EINVAL;
*checksum = TXGBE_EEPROM_SUM - *checksum;
return 0; return 0;
} }