iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nvme: remove the GENHD_FL_UP check in nvme_ns_remove

Browse Source 
Early probe failure never reaches nvme_ns_remove, so GENHD_FL_UP must
be set at this point.  Remove the check.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20210809064028.1198327-4-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Christoph Hellwig 2021-08-09 08:40:23 +02:00 committed by Jens Axboe
parent a94dcfce70
commit 5eba200526
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/nvme/host/core.c
View File

@ -3826,14 +3826,12 @@ static void nvme_ns_remove(struct nvme_ns *ns)
nvme_mpath_clear_current_path(ns); nvme_mpath_clear_current_path(ns);
synchronize_srcu(&ns->head->srcu); /* wait for concurrent submissions */ synchronize_srcu(&ns->head->srcu); /* wait for concurrent submissions */
if (ns->disk->flags & GENHD_FL_UP) { if (!nvme_ns_head_multipath(ns->head))
if (!nvme_ns_head_multipath(ns->head)) nvme_cdev_del(&ns->cdev, &ns->cdev_device);
nvme_cdev_del(&ns->cdev, &ns->cdev_device); del_gendisk(ns->disk);
del_gendisk(ns->disk); blk_cleanup_queue(ns->queue);
blk_cleanup_queue(ns->queue); if (blk_get_integrity(ns->disk))
if (blk_get_integrity(ns->disk)) blk_integrity_unregister(ns->disk);
blk_integrity_unregister(ns->disk);
}
down_write(&ns->ctrl->namespaces_rwsem); down_write(&ns->ctrl->namespaces_rwsem);
list_del_init(&ns->list); list_del_init(&ns->list);