iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Input: vmmouse - remove port reservation

Browse Source 
The VMWare EFI BIOS will expose port 0x5658 as an ACPI resource.  This
causes the port to be reserved by the APCI module as the system comes up,
making it unavailable to be reserved again by other drivers, thus
preserving this VMWare port for special use in a VMWare guest.

This port is designed to be shared among multiple VMWare services, such as
the VMMOUSE.  Because of this, VMMOUSE should not try to reserve this port
on its own.

The VMWare non-EFI BIOS does not do this to preserve compatibility with
existing/legacy VMs.  It is known that there is small chance a VM may be
configured such that these ports get reserved by other non-VMWare devices,
and if this ever happens, the result is undefined.

Signed-off-by: Sinclair Yeh <syeh@vmware.com>
Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
Cc: <stable@vger.kernel.org> # 4.1-
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
This commit is contained in:
Sinclair Yeh 2016-06-23 17:37:34 -07:00 committed by Dmitry Torokhov
parent 226ba70774
commit 60842ef812
1 changed files with 2 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
drivers/input/mouse/vmmouse.c
View File

@ -355,18 +355,11 @@ int vmmouse_detect(struct psmouse *psmouse, bool set_properties)
return -ENXIO; return -ENXIO;
} }
if (!request_region(VMMOUSE_PROTO_PORT, 4, "vmmouse")) {
psmouse_dbg(psmouse, "VMMouse port in use.\n");
return -EBUSY;
}
/* Check if the device is present */ /* Check if the device is present */
response = ~VMMOUSE_PROTO_MAGIC; response = ~VMMOUSE_PROTO_MAGIC;
VMMOUSE_CMD(GETVERSION, 0, version, response, dummy1, dummy2); VMMOUSE_CMD(GETVERSION, 0, version, response, dummy1, dummy2);
if (response != VMMOUSE_PROTO_MAGIC || version == 0xffffffffU) { if (response != VMMOUSE_PROTO_MAGIC || version == 0xffffffffU)
release_region(VMMOUSE_PROTO_PORT, 4);
return -ENXIO; return -ENXIO;
}
if (set_properties) { if (set_properties) {
psmouse->vendor = VMMOUSE_VENDOR; psmouse->vendor = VMMOUSE_VENDOR;
@ -374,8 +367,6 @@ int vmmouse_detect(struct psmouse *psmouse, bool set_properties)
psmouse->model = version; psmouse->model = version;
} }
release_region(VMMOUSE_PROTO_PORT, 4);
return 0; return 0;
} }
@ -394,7 +385,6 @@ static void vmmouse_disconnect(struct psmouse *psmouse)
psmouse_reset(psmouse); psmouse_reset(psmouse);
input_unregister_device(priv->abs_dev); input_unregister_device(priv->abs_dev);
kfree(priv); kfree(priv);
release_region(VMMOUSE_PROTO_PORT, 4);
} }
/** /**
@ -438,15 +428,10 @@ int vmmouse_init(struct psmouse *psmouse)
struct input_dev *rel_dev = psmouse->dev, *abs_dev; struct input_dev *rel_dev = psmouse->dev, *abs_dev;
int error; int error;
if (!request_region(VMMOUSE_PROTO_PORT, 4, "vmmouse")) {
psmouse_dbg(psmouse, "VMMouse port in use.\n");
return -EBUSY;
}
psmouse_reset(psmouse); psmouse_reset(psmouse);
error = vmmouse_enable(psmouse); error = vmmouse_enable(psmouse);
if (error) if (error)
goto release_region; return error;
priv = kzalloc(sizeof(*priv), GFP_KERNEL); priv = kzalloc(sizeof(*priv), GFP_KERNEL);
abs_dev = input_allocate_device(); abs_dev = input_allocate_device();
@ -502,8 +487,5 @@ init_fail:
kfree(priv); kfree(priv);
psmouse->private = NULL; psmouse->private = NULL;
release_region:
release_region(VMMOUSE_PROTO_PORT, 4);
return error; return error;
} }