iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ibmvnic: Disable irqs before exiting reset from closed state

Browse Source 
When the driver is closed, all the associated irqs are disabled. In the
event that the driver exits a reset in the closed state, we should be
consistent with the state we are in directly after a close. So before we
exit the reset routine, all irqs should be disabled as well. This will
prevent the irqs from being enabled twice in this case and reporting a
number of noisy warning traces.

Signed-off-by: John Allen <jallen@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
John Allen 2018-03-30 13:44:21 -05:00 committed by David S. Miller
parent da01ec4ee5
commit 6095e590d2
1 changed files with 18 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
drivers/net/ethernet/ibm/ibmvnic.c
View File

@ -1167,19 +1167,11 @@ static void clean_tx_pools(struct ibmvnic_adapter *adapter)
} }
} }
static void ibmvnic_cleanup(struct net_device *netdev) static void ibmvnic_disable_irqs(struct ibmvnic_adapter *adapter)
{ {
struct ibmvnic_adapter *adapter = netdev_priv(netdev); struct net_device *netdev = adapter->netdev;
int i; int i;
/* ensure that transmissions are stopped if called by do_reset */
if (adapter->resetting)
netif_tx_disable(netdev);
else
netif_tx_stop_all_queues(netdev);
ibmvnic_napi_disable(adapter);
if (adapter->tx_scrq) { if (adapter->tx_scrq) {
for (i = 0; i < adapter->req_tx_queues; i++) for (i = 0; i < adapter->req_tx_queues; i++)
if (adapter->tx_scrq[i]->irq) { if (adapter->tx_scrq[i]->irq) {
@ -1198,6 +1190,21 @@ static void ibmvnic_cleanup(struct net_device *netdev)
} }
} }
} }
}
static void ibmvnic_cleanup(struct net_device *netdev)
{
struct ibmvnic_adapter *adapter = netdev_priv(netdev);
/* ensure that transmissions are stopped if called by do_reset */
if (adapter->resetting)
netif_tx_disable(netdev);
else
netif_tx_stop_all_queues(netdev);
ibmvnic_napi_disable(adapter);
ibmvnic_disable_irqs(adapter);
clean_rx_pools(adapter); clean_rx_pools(adapter);
clean_tx_pools(adapter); clean_tx_pools(adapter);
} }
@ -1772,6 +1779,7 @@ static int do_reset(struct ibmvnic_adapter *adapter,
} }
} }
ibmvnic_disable_irqs(adapter);
adapter->state = VNIC_CLOSED; adapter->state = VNIC_CLOSED;
if (reset_state == VNIC_CLOSED) if (reset_state == VNIC_CLOSED)