iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

video: fbdev: mmp: replace usage of found with dedicated list iterator variable

Browse Source 
To move the list iterator variable into the list_for_each_entry_*()
macro in the future it should be avoided to use the list iterator
variable after the loop body.

To *never* use the list iterator variable after the loop it was
concluded to use a separate iterator variable instead of a
found boolean [1].

This removes the need to use a found variable and simply checking if
the variable was set, can determine if the break/goto was hit.

Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/ [1]
Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>
This commit is contained in:
Jakob Koschel 2022-04-01 00:35:03 +02:00 committed by Helge Deller
parent c40b65304c
commit 610323d8f6
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/video/fbdev/mmp/core.c
View File

@ -127,19 +127,18 @@ EXPORT_SYMBOL_GPL(mmp_unregister_panel);
*/ */
struct mmp_path *mmp_get_path(const char *name) struct mmp_path *mmp_get_path(const char *name)
{ {
struct mmp_path *path; struct mmp_path *path = NULL, *iter;
int found = 0;
mutex_lock(&disp_lock); mutex_lock(&disp_lock);
list_for_each_entry(path, &path_list, node) { list_for_each_entry(iter, &path_list, node) {
if (!strcmp(name, path->name)) { if (!strcmp(name, iter->name)) {
found = 1; path = iter;
break; break;
} }
} }
mutex_unlock(&disp_lock); mutex_unlock(&disp_lock);
return found ? path : NULL; return path;
} }
EXPORT_SYMBOL_GPL(mmp_get_path); EXPORT_SYMBOL_GPL(mmp_get_path);