iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Staging: comedi: fix printk issue in cb_pcidio.c

Browse Source 
This is a patch to the cb_pcidio.c file that fixes up a printk
warning found by the checkpatch.pl tool.

converted printks to dev_printk and Removed unnecessary printk
statements.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Ravishankar karkala Mallikarjunayya 2011-11-19 10:06:43 +05:30 committed by Greg Kroah-Hartman
parent 143c128cc1
commit 610b8ed959
1 changed files with 8 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
drivers/staging/comedi/drivers/cb_pcidio.c
View File

@ -184,8 +184,6 @@ static int pcidio_attach(struct comedi_device *dev, struct comedi_devconfig *it)
int index; int index;
int i; int i;
printk("comedi%d: cb_pcidio: \n", dev->minor);
/* /*
* Allocate the private structure area. alloc_private() is a * Allocate the private structure area. alloc_private() is a
* convenient macro defined in comedidev.h. * convenient macro defined in comedidev.h.
@ -223,8 +221,7 @@ static int pcidio_attach(struct comedi_device *dev, struct comedi_devconfig *it)
} }
} }
printk("No supported ComputerBoards/MeasurementComputing card found on " dev_err(dev->hw_dev, "No supported ComputerBoards/MeasurementComputing card found on requested position\n");
"requested position\n");
return -EIO; return -EIO;
found: found:
@ -236,14 +233,12 @@ found:
dev->board_name = thisboard->name; dev->board_name = thisboard->name;
devpriv->pci_dev = pcidev; devpriv->pci_dev = pcidev;
printk("Found %s on bus %i, slot %i\n", thisboard->name, dev_dbg(dev->hw_dev, "Found %s on bus %i, slot %i\n", thisboard->name,
devpriv->pci_dev->bus->number, devpriv->pci_dev->bus->number,
PCI_SLOT(devpriv->pci_dev->devfn)); PCI_SLOT(devpriv->pci_dev->devfn));
if (comedi_pci_enable(pcidev, thisboard->name)) { if (comedi_pci_enable(pcidev, thisboard->name))
printk
("cb_pcidio: failed to enable PCI device and request regions\n");
return -EIO; return -EIO;
}
devpriv->dio_reg_base devpriv->dio_reg_base
= =
pci_resource_start(devpriv->pci_dev, pci_resource_start(devpriv->pci_dev,
@ -259,11 +254,10 @@ found:
for (i = 0; i < thisboard->n_8255; i++) { for (i = 0; i < thisboard->n_8255; i++) {
subdev_8255_init(dev, dev->subdevices + i, subdev_8255_init(dev, dev->subdevices + i,
NULL, devpriv->dio_reg_base + i * 4); NULL, devpriv->dio_reg_base + i * 4);
printk(" subdev %d: base = 0x%lx\n", i, dev_dbg(dev->hw_dev, "subdev %d: base = 0x%lx\n", i,
devpriv->dio_reg_base + i * 4); devpriv->dio_reg_base + i * 4);
} }
printk("attached\n");
return 1; return 1;
} }
@ -277,7 +271,6 @@ found:
*/ */
static int pcidio_detach(struct comedi_device *dev) static int pcidio_detach(struct comedi_device *dev)
{ {
printk("comedi%d: cb_pcidio: remove\n", dev->minor);
if (devpriv) { if (devpriv) {
if (devpriv->pci_dev) { if (devpriv->pci_dev) {
if (devpriv->dio_reg_base) if (devpriv->dio_reg_base)