iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ata: libata-core: remove redundant err_mask variable

Browse Source 
Return value from ata_exec_internal() directly instead of
taking this in another redundant variable.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
This commit is contained in:
Jinpeng Cui 2022-08-23 12:29:14 +00:00 committed by Damien Le Moal
parent fee6073051
commit 614065aba7
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/ata/libata-core.c
View File

@ -4340,7 +4340,6 @@ static unsigned int ata_dev_set_xfermode(struct ata_device *dev)
unsigned int ata_dev_set_feature(struct ata_device *dev, u8 subcmd, u8 action) unsigned int ata_dev_set_feature(struct ata_device *dev, u8 subcmd, u8 action)
{ {
struct ata_taskfile tf; struct ata_taskfile tf;
unsigned int err_mask;
unsigned int timeout = 0; unsigned int timeout = 0;
/* set up set-features taskfile */ /* set up set-features taskfile */
@ -4356,9 +4355,8 @@ unsigned int ata_dev_set_feature(struct ata_device *dev, u8 subcmd, u8 action)
if (subcmd == SETFEATURES_SPINUP) if (subcmd == SETFEATURES_SPINUP)
timeout = ata_probe_timeout ? timeout = ata_probe_timeout ?
ata_probe_timeout * 1000 : SETFEATURES_SPINUP_TIMEOUT; ata_probe_timeout * 1000 : SETFEATURES_SPINUP_TIMEOUT;
err_mask = ata_exec_internal(dev, &tf, NULL, DMA_NONE, NULL, 0, timeout);
return err_mask; return ata_exec_internal(dev, &tf, NULL, DMA_NONE, NULL, 0, timeout);
} }
EXPORT_SYMBOL_GPL(ata_dev_set_feature); EXPORT_SYMBOL_GPL(ata_dev_set_feature);