iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tee: optee: Fix unsigned comparison with less than zero

Browse Source 
The return from the call to tee_client_invoke_func can be a
negative error code however this is being assigned to an
unsigned variable 'ret' hence the check is always false.
Fix this by making 'ret' an int.

Detected by Coccinelle ("Unsigned expression compared with zero:
ret < 0")

Fixes: c3fa24af92 ("tee: optee: add TEE bus device enumeration support")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Sumit Garg <sumit.garg@linaro.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
This commit is contained in:
YueHaibing 2019-02-19 15:04:28 +08:00 committed by Arnd Bergmann
parent 8deed84744
commit 62ade1bed2
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/tee/optee/device.c
View File

@ -34,7 +34,7 @@ static int optee_ctx_match(struct tee_ioctl_version_data *ver, const void *data)
static int get_devices(struct tee_context *ctx, u32 session, static int get_devices(struct tee_context *ctx, u32 session,
struct tee_shm *device_shm, u32 *shm_size) struct tee_shm *device_shm, u32 *shm_size)
{ {
u32 ret = 0; int ret = 0;
struct tee_ioctl_invoke_arg inv_arg; struct tee_ioctl_invoke_arg inv_arg;
struct tee_param param[4]; struct tee_param param[4];