iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

igmp: Fix a data-race around sysctl_igmp_max_memberships.

Browse Source 
While reading sysctl_igmp_max_memberships, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its reader.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Kuniyuki Iwashima 2022-07-15 10:17:42 -07:00 committed by David S. Miller
parent f6da2267e7
commit 6305d821e3
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
net/ipv4/igmp.c
View File

@ -2197,7 +2197,7 @@ static int __ip_mc_join_group(struct sock *sk, struct ip_mreqn *imr,
count++; count++;
} }
err = -ENOBUFS; err = -ENOBUFS;
if (count >= net->ipv4.sysctl_igmp_max_memberships) if (count >= READ_ONCE(net->ipv4.sysctl_igmp_max_memberships))
goto done; goto done;
iml = sock_kmalloc(sk, sizeof(*iml), GFP_KERNEL); iml = sock_kmalloc(sk, sizeof(*iml), GFP_KERNEL);
if (!iml) if (!iml)