iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

scsi: Change SCSI device boolean fields to single bit flags

Browse Source 
Commit 3cc2ffe5c1 ("scsi: sd: Differentiate system and runtime start/stop
management") changed the single bit manage_start_stop flag into 2 boolean
fields of the SCSI device structure. Commit 24eca2dce0 ("scsi: sd:
Introduce manage_shutdown device flag") introduced the manage_shutdown
boolean field for the same structure. Together, these 2 commits increase
the size of struct scsi_device by 8 bytes by using booleans instead of
defining the manage_xxx fields as single bit flags, similarly to other
flags of this structure.

Avoid this unnecessary structure size increase and be consistent with the
definition of other flags by reverting the definitions of the manage_xxx
fields as single bit flags.

Fixes: 3cc2ffe5c1 ("scsi: sd: Differentiate system and runtime start/stop management")
Fixes: 24eca2dce0 ("scsi: sd: Introduce manage_shutdown device flag")
Cc: <stable@vger.kernel.org>
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Link: https://lore.kernel.org/r/20231120225631.37938-2-dlemoal@kernel.org
Reviewed-by: Niklas Cassel <niklas.cassel@wdc.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Damien Le Moal 2023-11-21 07:56:30 +09:00 committed by Martin K. Petersen
parent 93e6c0e19d
commit 6371be7aeb
3 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/ata/libata-scsi.c
View File

@ -1056,8 +1056,8 @@ int ata_scsi_dev_config(struct scsi_device *sdev, struct ata_device *dev)
* and resume and shutdown only. For system level suspend/resume, * and resume and shutdown only. For system level suspend/resume,
* devices power state is handled directly by libata EH. * devices power state is handled directly by libata EH.
*/ */
sdev->manage_runtime_start_stop = true; sdev->manage_runtime_start_stop = 1;
sdev->manage_shutdown = true; sdev->manage_shutdown = 1;
} }
/* /*

6
drivers/firewire/sbp2.c
View File

@ -1519,9 +1519,9 @@ static int sbp2_scsi_slave_configure(struct scsi_device *sdev)
sdev->use_10_for_rw = 1; sdev->use_10_for_rw = 1;
if (sbp2_param_exclusive_login) { if (sbp2_param_exclusive_login) {
sdev->manage_system_start_stop = true; sdev->manage_system_start_stop = 1;
sdev->manage_runtime_start_stop = true; sdev->manage_runtime_start_stop = 1;
sdev->manage_shutdown = true; sdev->manage_shutdown = 1;
} }
if (sdev->type == TYPE_ROM) if (sdev->type == TYPE_ROM)

6
include/scsi/scsi_device.h
View File

@ -167,19 +167,19 @@ struct scsi_device {
* power state for system suspend/resume (suspend to RAM and * power state for system suspend/resume (suspend to RAM and
* hibernation) operations. * hibernation) operations.
*/ */
bool manage_system_start_stop; unsigned manage_system_start_stop:1;
/* /*
* If true, let the high-level device driver (sd) manage the device * If true, let the high-level device driver (sd) manage the device
* power state for runtime device suspand and resume operations. * power state for runtime device suspand and resume operations.
*/ */
bool manage_runtime_start_stop; unsigned manage_runtime_start_stop:1;
/* /*
* If true, let the high-level device driver (sd) manage the device * If true, let the high-level device driver (sd) manage the device
* power state for system shutdown (power off) operations. * power state for system shutdown (power off) operations.
*/ */
bool manage_shutdown; unsigned manage_shutdown:1;
unsigned removable:1; unsigned removable:1;
unsigned changed:1; /* Data invalid due to media change */ unsigned changed:1; /* Data invalid due to media change */