iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

misc/pvpanic: fix return value check in pvpanic_pci_probe()

Browse Source 
In case of error, the function pci_iomap() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Qiheng Lin <linqiheng@huawei.com>
Link: https://lore.kernel.org/r/20210330013659.916-1-linqiheng@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Qiheng Lin 2021-03-30 09:36:59 +08:00 committed by Greg Kroah-Hartman
parent d72260cc78
commit 642fa28bb5
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/misc/pvpanic/pvpanic-pci.c
View File

@ -83,8 +83,8 @@ static int pvpanic_pci_probe(struct pci_dev *pdev,
return ret; return ret;
base = pci_iomap(pdev, 0, 0); base = pci_iomap(pdev, 0, 0);
if (IS_ERR(base)) if (!base)
return PTR_ERR(base); return -ENOMEM;
pi = kmalloc(sizeof(*pi), GFP_ATOMIC); pi = kmalloc(sizeof(*pi), GFP_ATOMIC);
if (!pi) if (!pi)