iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

media: xilinx-vipp: Clean up bound async notifier callback

Browse Source 
The async notifier bound callback does a lot of checks that have probably
been always unnecessary. Remove the lookup of the async subev that we
already have, as well as the debug print that is already printed by the
framework.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Tested-by: Philipp Zabel <p.zabel@pengutronix.de> # imx6qp
Tested-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> # rcar + adv746x
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Tested-by: Aishwarya Kothari <aishwarya.kothari@toradex.com> # Apalis i.MX6Q with TC358743
Tested-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> # Renesas RZ/G2L SMARC
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
This commit is contained in:
Sakari Ailus 2023-04-18 13:07:28 +02:00 committed by Mauro Carvalho Chehab
parent eb934fa7b9
commit 645858055d
1 changed files with 5 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
drivers/media/platform/xilinx/xilinx-vipp.c
View File

@ -312,36 +312,14 @@ static int xvip_graph_notify_complete(struct v4l2_async_notifier *notifier)
static int xvip_graph_notify_bound(struct v4l2_async_notifier *notifier,
struct v4l2_subdev *subdev,
struct v4l2_async_subdev *unused)
struct v4l2_async_subdev *asd)
{
struct xvip_composite_device *xdev =
container_of(notifier, struct xvip_composite_device, notifier);
struct xvip_graph_entity *entity;
struct v4l2_async_subdev *asd;
struct xvip_graph_entity *entity = to_xvip_entity(asd);
/* Locate the entity corresponding to the bound subdev and store the
* subdev pointer.
*/
list_for_each_entry(asd, &xdev->notifier.asd_list, asd_list) {
entity = to_xvip_entity(asd);
entity->entity = &subdev->entity;
entity->subdev = subdev;
if (entity->asd.match.fwnode != subdev->fwnode)
continue;
if (entity->subdev) {
dev_err(xdev->dev, "duplicate subdev for node %p\n",
entity->asd.match.fwnode);
return -EINVAL;
}
dev_dbg(xdev->dev, "subdev %s bound\n", subdev->name);
entity->entity = &subdev->entity;
entity->subdev = subdev;
return 0;
}
dev_err(xdev->dev, "no entity for subdev %s\n", subdev->name);
return -EINVAL;
return 0;
}
static const struct v4l2_async_notifier_operations xvip_graph_notify_ops = {