iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Input: tsc200x - use EXPORT_GPL_SIMPLE_DEV_PM_OPS()

Browse Source 
SIMPLE_DEV_PM_OPS() is deprecated as it requires explicit protection
against unused function warnings.  The new combination of pm_sleep_ptr()
and EXPORT_GPL_SIMPLE_DEV_PM_OPS() allows the compiler to see the
functions, thus suppressing the warning, but still allowing the unused
code to be removed. Thus also drop the __maybe_unused markings.
This function also removes the need for separate EXPORT_SYMBOL_GPL()

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Link: https://lore.kernel.org/r/20230114171620.42891-10-jic23@kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
This commit is contained in:
Jonathan Cameron 2023-01-14 17:16:13 +00:00 committed by Dmitry Torokhov
parent 40be06463e
commit 6470215b88
3 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/input/touchscreen/tsc2004.c
View File

@ -65,7 +65,7 @@ static struct i2c_driver tsc2004_driver = {
.driver = { .driver = {
.name = "tsc2004", .name = "tsc2004",
.of_match_table = of_match_ptr(tsc2004_of_match), .of_match_table = of_match_ptr(tsc2004_of_match),
.pm = &tsc200x_pm_ops, .pm = pm_sleep_ptr(&tsc200x_pm_ops),
}, },
.id_table = tsc2004_idtable, .id_table = tsc2004_idtable,
.probe_new = tsc2004_probe, .probe_new = tsc2004_probe,

2
drivers/input/touchscreen/tsc2005.c
View File

@ -81,7 +81,7 @@ static struct spi_driver tsc2005_driver = {
.driver = { .driver = {
.name = "tsc2005", .name = "tsc2005",
.of_match_table = of_match_ptr(tsc2005_of_match), .of_match_table = of_match_ptr(tsc2005_of_match),
.pm = &tsc200x_pm_ops, .pm = pm_sleep_ptr(&tsc200x_pm_ops),
}, },
.probe = tsc2005_probe, .probe = tsc2005_probe,
.remove = tsc2005_remove, .remove = tsc2005_remove,

7
drivers/input/touchscreen/tsc200x-core.c
View File

@ -588,7 +588,7 @@ void tsc200x_remove(struct device *dev)
} }
EXPORT_SYMBOL_GPL(tsc200x_remove); EXPORT_SYMBOL_GPL(tsc200x_remove);
static int __maybe_unused tsc200x_suspend(struct device *dev) static int tsc200x_suspend(struct device *dev)
{ {
struct tsc200x *ts = dev_get_drvdata(dev); struct tsc200x *ts = dev_get_drvdata(dev);
@ -604,7 +604,7 @@ static int __maybe_unused tsc200x_suspend(struct device *dev)
return 0; return 0;
} }
static int __maybe_unused tsc200x_resume(struct device *dev) static int tsc200x_resume(struct device *dev)
{ {
struct tsc200x *ts = dev_get_drvdata(dev); struct tsc200x *ts = dev_get_drvdata(dev);
@ -620,8 +620,7 @@ static int __maybe_unused tsc200x_resume(struct device *dev)
return 0; return 0;
} }
SIMPLE_DEV_PM_OPS(tsc200x_pm_ops, tsc200x_suspend, tsc200x_resume); EXPORT_GPL_SIMPLE_DEV_PM_OPS(tsc200x_pm_ops, tsc200x_suspend, tsc200x_resume);
EXPORT_SYMBOL_GPL(tsc200x_pm_ops);
MODULE_AUTHOR("Lauri Leukkunen <lauri.leukkunen@nokia.com>"); MODULE_AUTHOR("Lauri Leukkunen <lauri.leukkunen@nokia.com>");
MODULE_DESCRIPTION("TSC200x Touchscreen Driver Core"); MODULE_DESCRIPTION("TSC200x Touchscreen Driver Core");