iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drm/xe: Do not take any action if our device was removed.

Browse Source 
Unfortunately devcoredump infrastructure does not provide and
interface for us to force the device removal upon the pci_remove
time of our device.

The devcoredump is linked at the device level, so when in use
it will prevent the module removal, but it doesn't prevent the
call of the pci_remove callback. This callback cannot fail
anyway and we end up clearing and freeing the entire pci device.

Hence, after we removed the pci device, we shouldn't allow any
read or free operations to avoid segmentation fault.

Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
This commit is contained in:
Rodrigo Vivi 2023-05-16 10:54:07 -04:00
parent e799485044
commit 656d29506c
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/gpu/drm/xe/xe_devcoredump.c
View File

@ -57,6 +57,10 @@ static ssize_t xe_devcoredump_read(char *buffer, loff_t offset,
struct drm_print_iterator iter;
struct timespec64 ts;
/* Our device is gone already... */
if (!data || !coredump_to_xe(coredump))
return -ENODEV;
iter.data = buffer;
iter.offset = 0;
iter.start = offset;
@ -81,6 +85,10 @@ static void xe_devcoredump_free(void *data)
{
struct xe_devcoredump *coredump = data;
/* Our device is gone. Nothing to do... */
if (!data || !coredump_to_xe(coredump))
return;
coredump->captured = false;
drm_info(&coredump_to_xe(coredump)->drm,
"Xe device coredump has been deleted.\n");