iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

usb: gadget: Add missing annotation for xudc_handle_setup()

Browse Source 
Sparse reports a warning at xudc_handle_setup()

warning: context imbalance in xudc_handle_setup() - unexpected unlock

The root cause is the missing annotation at xudc_handle_setup()

Add the missing __must_hold(&udc->lock) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
This commit is contained in:
Jules Irenge 2020-04-29 11:05:23 +01:00 committed by Felipe Balbi
parent 46b11a9112
commit 66bd76e79e
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/usb/gadget/udc/udc-xilinx.c
View File

@ -1732,6 +1732,7 @@ static void xudc_set_clear_feature(struct xusb_udc *udc)
* Process setup packet and delegate to gadget layer. * Process setup packet and delegate to gadget layer.
*/ */
static void xudc_handle_setup(struct xusb_udc *udc) static void xudc_handle_setup(struct xusb_udc *udc)
__must_hold(&udc->lock)
{ {
struct xusb_ep *ep0 = &udc->ep[0]; struct xusb_ep *ep0 = &udc->ep[0];
struct usb_ctrlrequest setup; struct usb_ctrlrequest setup;