iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nvmet: fix comparison of a u16 with -1

Browse Source 
Currently the u16 req->error_loc is being compared to -1 which
will always be false.  Fix this by casting -1 to u16 to fix this.

Detected by clang:
  warning: result of comparison of constant -1 with expression of
  type 'u16' (aka 'unsigned short') is always false
  [-Wtautological-constant-out-of-range-compare]

Fixes: 76574f37bf ("nvmet: add interface to update error-log page")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
This commit is contained in:
Colin Ian King 2018-12-14 18:31:21 +00:00 committed by Christoph Hellwig
parent cd19181bf9
commit 66c6afbd73
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/nvme/target/core.c
View File

@ -663,7 +663,7 @@ static void nvmet_set_error(struct nvmet_req *req, u16 status)
req->rsp->status = cpu_to_le16(status << 1);
if (!ctrl || req->error_loc == -1)
if (!ctrl || req->error_loc == (u16)-1)
return;
spin_lock_irqsave(&ctrl->error_lock, flags);