iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

PCI: hv: Convert remove_lock to refcount

Browse Source 
Use refcount instead of atomic for the reference counting
on bus. Refcount is safer because it handles overflow correctly.

Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
[lorenzo.pieralisi@arm.com: updated commit subject]
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
This commit is contained in:
Stephen Hemminger 2018-05-23 10:11:13 -07:00 committed by Lorenzo Pieralisi
parent 8c99e120ff
commit 6708be9367
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/pci/host/pci-hyperv.c
View File

@ -433,7 +433,7 @@ enum hv_pcibus_state {
struct hv_pcibus_device { struct hv_pcibus_device {
struct pci_sysdata sysdata; struct pci_sysdata sysdata;
enum hv_pcibus_state state; enum hv_pcibus_state state;
atomic_t remove_lock; refcount_t remove_lock;
struct hv_device *hdev; struct hv_device *hdev;
resource_size_t low_mmio_space; resource_size_t low_mmio_space;
resource_size_t high_mmio_space; resource_size_t high_mmio_space;
@ -2430,12 +2430,12 @@ static int hv_send_resources_released(struct hv_device *hdev)
static void get_hvpcibus(struct hv_pcibus_device *hbus) static void get_hvpcibus(struct hv_pcibus_device *hbus)
{ {
atomic_inc(&hbus->remove_lock); refcount_inc(&hbus->remove_lock);
} }
static void put_hvpcibus(struct hv_pcibus_device *hbus) static void put_hvpcibus(struct hv_pcibus_device *hbus)
{ {
if (atomic_dec_and_test(&hbus->remove_lock)) if (refcount_dec_and_test(&hbus->remove_lock))
complete(&hbus->remove_event); complete(&hbus->remove_event);
} }
@ -2479,7 +2479,7 @@ static int hv_pci_probe(struct hv_device *hdev,
hdev->dev_instance.b[8] << 8; hdev->dev_instance.b[8] << 8;
hbus->hdev = hdev; hbus->hdev = hdev;
atomic_inc(&hbus->remove_lock); refcount_set(&hbus->remove_lock, 1);
INIT_LIST_HEAD(&hbus->children); INIT_LIST_HEAD(&hbus->children);
INIT_LIST_HEAD(&hbus->dr_list); INIT_LIST_HEAD(&hbus->dr_list);
INIT_LIST_HEAD(&hbus->resources_for_children); INIT_LIST_HEAD(&hbus->resources_for_children);