iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cxgb4: fix memory leak of qe on error exit path

Browse Source 
A memory leak of qe occurs when t4_sched_queue_unbind fails,
so fix this by free'ing qe on the error exit path.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Colin Ian King
2016-10-16 23:54:03 +01:00
committed by David S. Miller
parent 9a0b1e8ba4
commit 67b11e2ea7
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/ethernet/chelsio/cxgb4/sched.c
View File

@@ -210,8 +210,10 @@ static int t4_sched_queue_bind(struct port_info *pi, struct ch_sched_queue *p)
/* Unbind queue from any existing class */ /* Unbind queue from any existing class */
err = t4_sched_queue_unbind(pi, p); err = t4_sched_queue_unbind(pi, p);
if (err) if (err) {
t4_free_mem(qe);
goto out; goto out;
}
/* Bind queue to specified class */ /* Bind queue to specified class */
memset(qe, 0, sizeof(*qe)); memset(qe, 0, sizeof(*qe));